Merged
Conversation
Member
Author
|
You merged the upgrade rectors @markstory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #948
Deprecated Constants (all marked with
@deprecated 5.0.0):Since they all have the same string value, this should be fully BC
These are deprecated MySQL-specific types that don't have new equivalents since they're being removed:
These remain using their old names because they're deprecated themselves and will be removed entirely in a future version (afaik?). At least they dont have a matching constant in the Cake Schema interface.
This finishes the phinx cleanup, since now you can start using the new ones, and in 6.x (for Cake 6) we can remove all deprecations for good. Enough time for people to upgrade.
My rational is:
Rector automation PR: cakephp/upgrade#361